Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lb type param on terraform sdk #1023

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Support lb type param on terraform sdk #1023

merged 3 commits into from
Sep 20, 2023

Conversation

asaha2
Copy link
Contributor

@asaha2 asaha2 commented Aug 29, 2023

No description provided.

@asaha2 @andrewsomething
Update digitalocean/loadbalancer/resource_loadbalancer.go
447d0d6 
PR feedback

Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
andrewsomething
andrewsomething approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@andrewsomething andrewsomething merged commit 441d3a6 into digitalocean:main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfundaro-do lfundaro-do lfundaro-do left review comments

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asaha2 @andrewsomething @lfundaro-do